No error in init #457
Merged
No error in init #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the initialization and device handling logic of the UMP binding by removing error raises in the constructor and shifting error handling to the asynchronous accessor methods. Key changes include:
- Removing error checks and exceptions from init
- Refactoring get_manipulators to return an empty list for no devices
- Adjusting get_axes_count to handle the empty list case and calling get_axes_count in _is_ump_3
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ephys_link/bindings/ump_binding.py | Refactored device error handling and axis count logic |
| src/ephys_link/about.py | Version bump reflecting the new build version |
…in-init # Conflicts: # src/ephys_link/bindings/ump_binding.py
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/ephys_link/bindings/ump_binding.py:56
- Validating device axis consistency in get_manipulators() rather than during initialization may delay the detection of incompatible device configurations. Ensure that consumers of get_manipulators() can correctly handle the delayed error scenario.
if any(self._get_device(device_id).n_axes() != self.axis_count for device_id in device_ids): # pyright: ignore [reportUnknownArgumentType, reportUnknownMemberType]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Notes